pingcap / pingcap/tiup

should not output error log to file when found unrecognized flag

Open
#303 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Execute the command:

$ tiup cluster --dashboard
Starting component `cluster`: /Users/joshua/.tiup/components/cluster/v1.0.0/cluster --dashboard

Error: unknown flag: --dashboard

Verbose debug logs has been written to /Users/joshua/Desktop/Code/tiup/logs/tiup-cluster-debug-2020-05-29-23-28-35.log.
Error: run `/Users/joshua/.tiup/components/cluster/v1.0.0/cluster` (wd:/Users/joshua/.tiup/data/S0OKVKr) failed: exit status 1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce tiup cluster --dashboard and inspect the cluster command entry point and the logging path used for the unknown-flag error. Confirm the behavior when an unrecognized flag is supplied, then verify that the command reports the error without writing a verbose debug log file.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.