pingcap / pingcap/tiup

Ng monitoring may not restart

Open
#2,660 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Bug Report

https://github.com/pingcap/tiup/blob/master/embed/templates/scripts/run_prometheus.sh.tpl

Due to it is ran by one single script, signals may not be handled correctly

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with embed/templates/scripts/run_prometheus.sh.tpl and trace how the monitoring process is launched and receives termination signals. Reproduce the reported case and verify that monitoring restarts correctly after the relevant process or script termination.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.