Should not treat version as float to compare
Open
Nobody has claimed this yet.
type/bug
- Dominant language
- Go
- Stars
- 466
- Forks
- 338
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 8
Description
This function treats OS versions as float. However, version 8.10 is larger than version 8.4, while float 8.10 is not.
- What version of TiUP are you using (
tiup --version)?
latest
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review pkg/cluster/operation/check.go, especially lines 167-250, to understand how OS versions are currently compared. Verify the comparison with versions such as 8.10 and 8.4; done means version ordering no longer treats those values as floats.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100