pingcap / pingcap/tiup

Update github.com/xo/usql v0.9.5 -> v0.19.x

Open
#2,588 10 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

contribution type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Currently, TiUP depends on a version of usql from 2021:

github.com/xo/usql v0.9.5

See https://github.com/pingcap/tiup/blob/f6aa0ac09b9d6405929c2cea3c0207880e53d199/go.mod#L48

This version is of usql is so old that it itself has outdated and unmaintained dependencies, such as for example in https://github.com/xo/usql/blame/6228ccb8c84c99d34bfbd02da339edbb8a9c3c2e/env/env.go#L23 it uses zaf/temp, which has been deprecated since 2022 and its functionality has been included in the Go standard library since version 1.14 in the os package (os.CreateTemp and os.MkdirTemp).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the github.com/xo/usql entry in go.mod at the referenced location and inspect the dependency changes between v0.9.5 and v0.19.x. Update the module version, then run the repository's available Go checks; done means the newer usql version resolves cleanly without breaking TiUP.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.