Can not use nightly in offline mirror
Open
Nobody has claimed this yet.
type/bug
- Dominant language
- Go
- Stars
- 466
- Forks
- 338
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 8
Description
Bug Report
When clone offline without --full flag, and the version itself is not identical to nightly, the manifest will lack nightly setting. Thus any nightly-version-related operations to repository will fail.
- What did you do?
tiup mirror clone test -o xx -a xx xxx-nightly
-
What did you expect to see?
-
What did you see instead?
-
What version of TiUP are you using (
tiup --version)?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at pkg/repository/clone_mirror.go around lines 284-287 and reproduce the issue with tiup mirror clone test -o xx -a xx xxx-nightly without --full. Trace how the manifest is built when the requested version is not identical to nightly; done means nightly-version-related repository operations continue to work after the offline clone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100