pingcap / pingcap/tiup

Prometheus --web.external-url should be configurable

Open
#2,441 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Is your feature request related to a problem? Please describe:

Currently I cannot expose Prometheus behind a reverse proxy using /prometheus as prefix.

Describe the feature you'd like:

I would like the default --web.external-url to be overwritten when added to monitoring addiotional_args. Example usage:

  additional_args:
  - --web.external-url=https://example.org/prometheus

Why the featue is needed:

Exposing a service behind a reverse proxy with a different url is a common scenario.

Describe alternatives you've considered:

There is no alternative besides manually updating the run_prometheus.sh after every tiup run.

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how monitoring additional_args is read and how run_prometheus.sh is generated. Verify that a supplied --web.external-url can override the default, and confirm the generated command preserves the requested URL prefix.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devops, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.