Cannot use 'tiup cluster edit-config xxx' to modify the tidb slow query file path
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 466
- Forks
- 338
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 8
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
- What did you do?
-
use tiup cluster edit-config xxx to edit the slow query file path
server_configs:
tidb:
log.slow-query-file: /tidb-deploy/tidb-4000/log/testslow.log -
reload the cluster: tiup cluster reload xxx
-
check the slow query file path, found the value is /tidb-deploy/tidb-4000/log/tidb_slow_query.log, it should be testslow.log
show config where name like '%slow%';
- remove the slow-log command line configure from /tidb-deploy/deploy/tidb-4000/scripts/run_tidb.sh and then restart the cluster the new slow log path is used. But if tiup reload, it's overwrite again.
- What did you expect to see?
Using 'tiup cluster edit-config' to modify slow query file path should work.
- What did you see instead?
It does not work.
- What version of TiUP are you using (
tiup --version)?
master
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the tiup cluster edit-config and tiup cluster reload entry points, then inspect how server_configs.tidb.log.slow-query-file is rendered into /tidb-deploy/deploy/tidb-4000/scripts/run_tidb.sh. Reproduce the reload sequence from the issue and verify that the configured slow-query path is retained after reload.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100