pingcap / pingcap/tiup

Allow adding additional ip and domain names in tiup cluster ssl enable

Open
#2,321 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Is your feature request related to a problem? Please describe:
The ssl cert automatcally genrated by tiup does not include external ip of the server.

Describe the feature you'd like:
Allow adding additional ip and domain names in tiup cluster ssl enable

Why the featue is needed:
A host may have multiple ip addresses.

Describe alternatives you've considered:
use a custom certificate in tiup, but that would involve complicated steps with openssl, etc.

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the tiup cluster ssl enable command and the certificate-generation path it invokes. Trace how certificate names are currently collected, then define completion as allowing additional IP addresses and domain names to be included in the generated certificate; the issue names no specific tests or files to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.