Enable collector.ethtool in node_exporter
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 466
- Forks
- 338
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 8
Description
Feature Request
Is your feature request related to a problem? Please describe:
In cloud environments, it is common to encounter network limitations that can affect the performance and stability of the TiDB setup. Many users, including myself, have experienced network bottlenecks that can lead to issues like "bw_in_allowance_exceeded" and "bw_out_allowance_exceeded." This is especially prevalent when running TiDB on platforms like AWS, where network performance is closely monitored and has specific limits.
Example:
sudo ethtool -S eth0 | grep -i allow
bw_in_allowance_exceeded: 29434181
bw_out_allowance_exceeded: 129
Describe the feature you'd like:
I kindly request an update to the node_exporter component within the TiUP tool. Specifically, I propose enabling the "ethtool" collector in node_exporter. At the moment, the current version of node_exporter does not support this essential feature.
Why the featue is needed:
Describe alternatives you've considered:
By adding support for the ethtool collector in node_exporter, TiDB users will be able to obtain more relevant and detailed metrics regarding their cloud network usage. This enhancement will allow us to monitor key network performance parameters, helping to identify and address potential bottlenecks early on. Additionally, it will be particularly beneficial for users running TiDB in cloud environments, where network limitations can significantly impact the overall performance of the system.
I believe that this enhancement will greatly improve the monitoring capabilities of TiDB in cloud setups and will be highly appreciated by the community. As more and more users are adopting TiDB for cloud deployments, this feature will become increasingly valuable.
Teachability, Documentation, Adoption, Migration Strategy:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/monitoring-network-performance-ena.html
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TiUP component configuration for node_exporter and checking the bundled version's support for the ethtool collector. Validate that enabling it exposes the requested AWS network allowance metrics; the issue names no files or tests, so repository discovery is required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cloud, observability-sre
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100