pingcap / pingcap/tiup

Support flexible configuration of run_prometheus.sh

Open
#2,185 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Is your feature request related to a problem? Please describe:

1、Limit prometheus query spreading:
--query.timeout="5s" # default 2m
--query.max-concurrency=5 # default 20

2、Speed up restart time:
--enable-feature=memory-snapshot-on-shutdown

3、Enable WAL compression:
--storage.tsdb.wal-compression

All these optimizations need to be configured through run_prometheus.sh,eg:
exec bin/prometheus/prometheus
--config.file="/data1/webank_test11/tidb-deploy/prometheus-9291/conf/prometheus.yml"
--web.listen-address=":9291"
--web.external-url="http://172.16.4.204:9291/"
--web.enable-admin-api
--log.level="info"
*--query.timeout="500ms"
--query.max-concurrency=1
--enable-feature=memory-snapshot-on-shutdown *

--storage.tsdb.path="/data1/webank_test11/tidb-data/prometheus-9291"
--storage.tsdb.retention="30d"

Describe the feature you'd like:

Why the featue is needed:

All these optimizations need to be configured through run_prometheus.sh

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating run_prometheus.sh and review how it assembles the Prometheus command. Make the requested query, restart, and WAL-compression options configurable through that script, while preserving existing behavior when they are not set. Done means the script can pass these options to Prometheus as described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
prometheus, shell
Domain
devops, observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.