pingcap / pingcap/tiup

Why does tiup upgrade ignore the exporter agent?

Open
#2,115 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

I use tiup to upgrade a TiDB cluster from 5.1.4 to 5.1.5, node_exporter sholud 0.17 to 1.3, but no change.

Check the source code and find that exporter agent is ignored, what is the reason?

https://github.com/pingcap/tiup/blob/891c1e794c718380e1ca515a5955b19444c02d57/pkg/cluster/manager/upgrade.go#L92-L99

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pkg/cluster/manager/upgrade.go lines 92-99 and trace why the exporter agent is excluded during a TiUP upgrade from 5.1.4 to 5.1.5. Inspect the handling of node_exporter 0.17 to 1.3 and determine whether the behavior matches the intended upgrade path; done means the reason or required change is established and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.