pingcap / pingcap/tiup

tiup update --self always downloads the latest binary even if already up-to-date

Open
#1,904 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

tiup update --self
tiup update --self

  1. What did you expect to see?
    Only download the latest version if not already using it.

  2. What did you see instead?
    Every time tiup update --self is run, it will download the latest version, even if already running it.

  3. What version of TiUP are you using (tiup --version)?

1.9.6 tiup
Go Version: go1.17.10
Git Ref: v1.9.6
GitHash: 28965259aecd0a10ae72b69fc59121f6b4edd276

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior with tiup update --self twice on TiUP 1.9.6, then trace the CLI's self-update entry point and version check. Done means a second run recognizes the installed version as current and does not download the binary.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.