Make THP check less strict
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 466
- Forks
- 338
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 8
Description
Bug Report
Currently the THP check checks both /sys/kernel/mm/transparent_hugepage/enabled and /sys/kernel/mm/transparent_hugepage/defrag. To me it looks like having /enabled set to [never] should be sufficient.
This is with tiup v1.8.2
See also https://www.kernel.org/doc/Documentation/vm/transhuge.txt
This affects users that set transparent_hugepage=never as boot parameter as suggested in transhuge.txt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the THP check that reads /sys/kernel/mm/transparent_hugepage/enabled and /sys/kernel/mm/transparent_hugepage/defrag, then read the linked Linux transhuge documentation. Verify how the check handles transparent_hugepage=never and add or update coverage so completion is demonstrated when enabled is set to [never].
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100