pingcap / pingcap/tiup

The tiup cluster check command is added to print the results of the check for I/O scheduler

Open
#1,668 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Is your feature request related to a problem? Please describe:
When using tiup cluster check command, there are one important check items that are not printed

Describe the feature you'd like:
I hope that after the tiup cluster check command is executed, the I/O scheduler configuration information will be printed out, whether it is correct or not.

Why the featue is needed:
Do not print this information, it is easy to miss to check

Describe alternatives you've considered:
Pass the parameter check and print pass, if it fails, print the current value and mark it as warn

Teachability, Documentation, Adoption, Migration Strategy:
none

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of the tiup cluster check command and its existing check-result output. Trace how system checks are reported, then determine where the I/O scheduler check belongs. Done means the command reports whether the scheduler configuration passes and shows the current value with a warning when it fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, operating-systems
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.