pingcap / pingcap/tiup

Tiup should support modify ip for tidb and tikv

Open
#1,650 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

tiup edit-config hit following error.

Starting component cluster: /root/.tiup/components/cluster/v1.6.1/tiup-cluster edit-config drtest
New topology could not be saved: immutable field changed: TiDBServers.2.Host changed from '172.16.6.51' to '172.16.6.233', TiKVServers.2.Host changed from '172.16.6.51' to '172.16.6.233'

Since pd has support IP changing for tikv, tiup should support it so that customer can uses it.
Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Why the featue is needed:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the tiup cluster edit-config command and reproduce the reported topology update for TiDB and TiKV host IPs. Compare its immutable-field handling with the existing PD IP-change support described in the issue; done means those host IPs can be changed without the reported error.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.