pingcap / pingcap/tiup

Support name conflict check for dm-master/pd

Open
#1,602 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

a. Start a dm-cluster with 3 nodes, master1~3.
b. Scale-out dm-cluster with 3 nodes, but the names are wrong. They are still master1~3
c. Fail to scale-out. Try to scale-in the newly added nodes.
d. When tiup-dm scale-in, it will try to delete master1~3 and will affect the existing cluster.

  1. What did you expect to see?

  2. What did you see instead?

  3. What version of TiUP are you using (tiup --version)?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the tiup-dm scale-in flow described in the reproduction steps, especially how dm-master and pd node names are handled. Confirm the behavior with a three-node cluster and define done as preventing a scale-in from deleting existing nodes when newly added nodes reuse their names.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.