tiup should not start scale-in node
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 466
- Forks
- 338
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 8
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
-
What did you do?
Deploy a cluster with 4 nodes and using tiup to scale-in one of them. Stop the whole cluster and then start it again. -
What did you expect to see?
The cluster is started and only 3 nodes are serving. -
What did you see instead?
tiup tries to start the scale-in node, which is already tombstone and can't be started again. Hence the start command timeout in the end. -
What version of TiUP are you using (
tiup --version)?
tiup version 1.5.6 tiup
Go Version: go1.16.7
Git Ref: v1.5.6
GitHash: 1d1478dbec0d06ef5e909d3323331914538d4cb0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the tiup scale-in and cluster start command paths, reproducing the four-node scenario described in the report. Trace how the tombstone node is selected during startup; the work is done when restarting the scaled-in cluster starts only the three serving nodes without timing out.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100