Tiup mirror clone didn't fail when missming some component.
Open
Nobody has claimed this yet.
type/bug
- Dominant language
- Go
- Stars
- 466
- Forks
- 338
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 8
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
-
What did you do?
tiup set mirror ${localdir}
tiup mirror clone ${package name} v4.0.15 --os linux --arch arm64 -
What did you expect to see?
tiup mirror clone failed because local mirror didn't have linux-arm64 tiup. -
What did you see instead?
tiup mirror clone succeed and print this log:
TiUP donesn't have linux/arm64, skipped
- What version of TiUP are you using (
tiup --version)?
1.5.6 tiup
Go Version: go1.16.7
Git Ref: v1.5.6
GitHash: 1d1478dbec0d06ef5e909d3323331914538d4cb0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the tiup mirror clone command with a local mirror that lacks the linux-arm64 component, using the reported TiUP version and arguments. Trace the mirror-clone handling for the "skipped" log; done means the command fails when the requested component is missing rather than succeeding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100