pingcap / pingcap/tiup

Improve output for "Waiting for tidb instances ready"

Open
#1,454 1 comment 0 reactions 1 assignee View on GitHub

@9547 is already working on this.

Since Jun 28, 2021.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

In some cases tiup playground prints this message many times while it waits for tidb to be ready:
"Waiting for tidb instances ready"

Would be nice to have it print "Waiting for tidb instances ready" an then print a "." every second and move the cursor back again every 3s. Or the spinner animation that tiup uses elsewhere. Then it doesn't eat as much screen space.

I also think the message itself should be changed to "Waiting for tidb instances to be ready"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.