pingcap / pingcap/tiup

check version existence before asking if user want to continue during `tiup cluster upgrade`

Open
#1,374 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/cluster type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Describe the feature you'd like:
I attempted to upgrade the cluster to a version doesn't exist, tiup asked me Do you want to continue?, a better experience be like v4.0.1024 is an unknown version or something like that.

tiup cluster upgrade sa1 v4.0.1024
Starting component `cluster`: /home/tidb/.tiup/components/cluster/v1.4.3/tiup-cluster upgrade sa1 v4.0.1024
This operation will upgrade tidb v4.0.12 cluster sa1 to v4.0.1024.
Do you want to continue? [y/N]:(default=N) 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the tiup cluster upgrade command entry point and reproduce the upgrade with the nonexistent version v4.0.1024. Done means the command checks version existence before asking for confirmation and reports that the version is unknown.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.