multi tikv, and replication.max-replicas: 1, tiup should skip "evict leader"
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 466
- Forks
- 338
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 8
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
- What did you do?
using tiup to upgrade tidb v4.0.11 cluster to v5.0.1, tikv upgrading takes more than 20 minutes.
when eplication.max-replicas: 1, should not evict leader, should skip this step.
Upgrading component tikv
Evicting 9 leaders from store 10.0.2.189:20160...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer.
-
What did you expect to see?
-
What did you see instead?
tikv evict leader when eplication.max-replicas: 1
- What version of TiUP are you using (
tiup --version)?
[root@58a644893144 ~]# tiup --version
v1.3.7 tiup
Go Version: go1.13
Git Branch: release-1.3
GitHash: 37c95bb
[root@58a644893144 ~]# tiup cluster --version
Starting componentcluster: /root/.tiup/components/cluster/v1.4.0/tiup-cluster --version
tiup version 1.4.0 tiup
Go Version: go1.16.2
Git Ref: v1.4.0
GitHash: eb335e6ad9d0dc19d1c43db422cd409d62bc3cea
[root@58a644893144 ~]#
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the tiup cluster upgrade from TiDB v4.0.11 to v5.0.1 with replication.max-replicas set to 1, using the reported tiup and tiup cluster versions. Trace the upgrade path that prints “Evicting” and verify that this step is skipped for the single-replica configuration while the upgrade still completes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100