pingcap / pingcap/tiup

multi tikv, and replication.max-replicas: 1, tiup should skip "evict leader"

Open
#1,326 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    using tiup to upgrade tidb v4.0.11 cluster to v5.0.1, tikv upgrading takes more than 20 minutes.
    when eplication.max-replicas: 1, should not evict leader, should skip this step.

Upgrading component tikv
Evicting 9 leaders from store 10.0.2.189:20160...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer...
Still waitting for 9 store leaders to transfer.

  1. What did you expect to see?

  2. What did you see instead?

tikv evict leader when eplication.max-replicas: 1

  1. What version of TiUP are you using (tiup --version)?
    [root@58a644893144 ~]# tiup --version
    v1.3.7 tiup
    Go Version: go1.13
    Git Branch: release-1.3
    GitHash: 37c95bb
    [root@58a644893144 ~]# tiup cluster --version
    Starting component cluster: /root/.tiup/components/cluster/v1.4.0/tiup-cluster --version
    tiup version 1.4.0 tiup
    Go Version: go1.16.2
    Git Ref: v1.4.0
    GitHash: eb335e6ad9d0dc19d1c43db422cd409d62bc3cea
    [root@58a644893144 ~]#

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the tiup cluster upgrade from TiDB v4.0.11 to v5.0.1 with replication.max-replicas set to 1, using the reported tiup and tiup cluster versions. Trace the upgrade path that prints “Evicting” and verify that this step is skipped for the single-replica configuration while the upgrade still completes.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.