pingcap / pingcap/tiup

Test cases to avoid panel missing in Grafana

Open
#1,275 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

category/testing help wanted type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Is your feature request related to a problem? Please describe:
Like this issue, https://github.com/pingcap/tiup/pull/1083, tiup's cluster failed to add TiFlash nodes to Grafana's Node_exporter panel. And currently, we don't have test cases to cover this issue.

Describe the feature you'd like:

Test cases that promise we don't lose any components' panels in Grafana.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reviewing the referenced tiup pull request 1083 and the code and tests responsible for Grafana Node_exporter panels; add coverage that detects missing panels for every component, including TiFlash, and run the relevant test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.