pingcap / pingcap/tiup

at lease print a log for "no need to check tombestone"

Open
#1,148 0 comments 3 reactions 1 assignee View on GitHub

@srstack is already working on this.

Since Dec 21, 2021.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Is your feature request related to a problem? Please describe:

if the user delete tikv store not by tiup

it will just keep silent when run prune command since no any node scaling in tiup's view:
Screen Shot 2021-02-22 at 6 55 38 PM

but we can see the node is tombstone by display command.

also, no way to scale-in it again by tiup:
image

Describe the feature you'd like:

for prune command, at least print a log for what happen when no need to check tombstone.

for scale-in,maybe we can set Offline as true and make scale-in successful when the store already tombstone

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.