pingcap / pingcap/tiup

tiup cluster check report fail unexpectly

Open
#1,140 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

I run this command

tiup cluster check testing --cluster
  1. What did you expect to see?
    No Fail.
    I do not deploy tikv on the 172.16.4.84 node. So I think it's ok that mount point / does not have 'nodelalloc' option set. Here is a part of my topology.yaml that is related to 172.16.4.84.
global:
  user: "tidb"
  ssh_port: 22
  deploy_dir: "/home/testing/deploy"  # for monitor components
pd_servers:
  - host: 172.16.4.84
    ssh_port: 22
    client_port: 2379
    peer_port: 2380
    deploy_dir: "/data1/testing/pd-2379"
tidb_servers:
  - host: 172.16.4.84
    ssh_port: 22
    port: 4000
    status_port: 10080
    deploy_dir: "/data1/testing/tidb-4000"
    numa_node: "0"
monitoring_servers:
  - host: 172.16.4.84
    port: 9090
grafana_servers:
  - host: 172.16.4.84
    port: 3000
alertmanager_servers:
  - host: 172.16.4.84
    web_port: 9093
  1. What did you see instead?
172.16.4.84  disk            Fail    mount point / does not have 'nodelalloc' option set
172.16.4.84  disk            Warn    mount point / does not have 'noatime' option set
172.16.4.84  disk            Fail    mount point / does not have 'nodelalloc' option set
  1. What version of TiUP are you using (tiup --version)?
[root@localhost data-testing]# tiup --version
v1.3.2 tiup
Go Version: go1.13
Git Branch: release-1.3
GitHash: 2d88460
[root@localhost data-testing]# tiup cluster --version
Starting component `cluster`: /root/.tiup/components/cluster/v1.3.2/tiup-cluster --version
tiup version v1.3.2 tiup
Go Version: go1.13
Git Branch: release-1.3
GitHash: 2d88460

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing tiup cluster check testing --cluster with the topology and TiUP v1.3.2 details provided in the report. Trace the cluster check disk validation and compare its handling of the node roles and mount-point warnings; done when the command reports the expected result for this topology without the inappropriate failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.