pingcap / pingcap/tiup

Support set timeout for the command tiup mirror publish

Open
#1,002 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Is your feature request related to a problem? Please describe:

We support use the command tiup mirror publish to publish component at current, however, we may need to do something slow during the publish action, eg. uploading published tarball to CDN. It's easy to timeout at current because we hardcode 60s for the timeout value on TiUP client.

Describe the feature you'd like:

Add a --timeout flag to let the user choose the timeout value.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the implementation of the tiup mirror publish command and trace where the TiUP client’s hardcoded 60-second timeout is set. Add a user-selectable --timeout flag and verify that publishing can use the configured value, including for slow uploads such as CDN transfers.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.