pingcap / pingcap/tiproxy

Potential concurrency bug in logger

Open
#455 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
73
Forks
41
Avg merge
21h 3m
Merged PRs (30d)
21

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Start TiProxy with TiUP cluster.

2. What did you expect to see? (Required)

Always print welcome info.

3. What did you see instead (Required)

Theoretically, there's possibility that the welcome info is printed before initializing the log file, so the welcome info may not be printed.

4. What is your version? (Required)

master

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing TiProxy startup and logger initialization when launched with TiUP cluster, then investigate whether welcome information can be emitted before the log file is ready. Reproduce the reported ordering if possible and verify that welcome information is always printed after the initialization change.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.