pingcap / pingcap/tiproxy

Refactor `Authenticator.handshakeFirstTime()`

Open
#405 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

refactor
Dominant language
Go
Stars
73
Forks
41
Avg merge
21h 3m
Merged PRs (30d)
21

Description

Development Task

Now Authenticator.handshakeFirstTime() has over 180 lines and 2 goto labels. This makes code harder to read.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Authenticator.handshakeFirstTime() and reading its full 180-plus-line implementation, including both goto labels. The issue does not name a target decomposition, related tests, or a completion criterion, so clarify the intended structure and how behavior should be verified before making changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.