pingcap / pingcap/tiproxy

Check slice boundary when parsing packets

Open
#365 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

refactor
Dominant language
Go
Stars
73
Forks
41
Avg merge
21h 3m
Merged PRs (30d)
21

Description

Development Task

Most packet parsing in TiProxy doesn't check the boundaries and it may panic if the client sends a malformed packet. This is not good. We'd better check it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the packet-parsing entry points in TiProxy and tracing where input slices are indexed. Check the relevant parser tests or add focused malformed-packet cases; done means malformed client packets are handled without slice-boundary panics across the parsing paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.