pingcap / pingcap/tiproxy

Avoid recoverable panic before handshake stage

Open
#1,199 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
73
Forks
41
Avg merge
21h 3m
Merged PRs (30d)
21

Description

Development Task

Now TiProxy might report recoverable panic in many protocol related codes:

  1. For the packets before handshake.
  2. For the packets after handshake.
  3. For the packets from TiDB to client.

For this issue, I'm only going to fix the first class. Because: we can assume the TiDB always gives the correct format of packets (or there might be some incompability), and we might assume the client after logging in will always give a correct protocol.

For now, usually the recoverable panic is caused by the port scanning software on the internet.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing TiProxy's protocol-related packet handling for packets received before the handshake, focusing on paths that report recoverable panics. Confirm the relevant behavior with malformed or unexpected pre-handshake packets; done means those packets no longer produce recoverable panics while post-handshake and TiDB-to-client handling remain out of scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.