pingcap / pingcap/tiflash

The DataType instances are not shared when creating by `TiDB::ColumnInfo`

Open
#9,991 0 comments 0 reactions 1 assignee View on GitHub

@JaySon-Huang is already working on this.

Since Mar 11, 2025.

component/storage severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)
2. What did you expect to see? (Required)
3. What did you see instead (Required)

The way TiFlash handle newly create table is:

https://github.com/pingcap/tiflash/blob/b25fa23f95b04c31cd8a9e47945d659e127f4aed/dbms/src/TiDB/Schema/SchemaBuilder.cpp#L1046-L1072

https://github.com/pingcap/tiflash/blob/b25fa23f95b04c31cd8a9e47945d659e127f4aed/dbms/src/TiDB/Decode/TypeMapping.cpp#L202-L214

https://github.com/pingcap/tiflash/blob/b25fa23f95b04c31cd8a9e47945d659e127f4aed/dbms/src/TiDB/Decode/TypeMapping.cpp#L124-L132

4. What is your TiFlash version? (Required)

nightly

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.