pingcap / pingcap/tiflash

refine Aggregator code

Open
#9,949 0 comments 0 reactions 1 assignee View on GitHub

@guo-shaoge is already working on this.

Since Mar 6, 2025.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

For now, Aggregator.cpp is too complicated, it's too long, we should split it into different files, just like ClickHouse.

Split Aggregator.cpp to

  1. Aggregator.cpp: core aggregation logic
  2. AggregationMethod: all methods
  3. AggregatedDataVariants

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.