pingcap / pingcap/tiflash

support push calculation of type 'enum' to TiFlash

Open
#9,172 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Feature Request

Is your feature request related to a problem? Please describe:

  1. create table t0 and t1
create table t0(id int primary key, v int, vv enum('A1', 'A2', 'A3'));
create table t1(id int primary key, v int, vv enum('B1', 'B2', 'B3'));
  1. execute expain
explain analyze select/*+ read_from_storage(tiflash[a], tiflash[b]) */ a.v, b.v, a.vv, b.vv from t0 a join t1 b on a.id=b.id where a.vv='A1';

image

there are some warnings:
image

enum type is used frequently as basic type, so why TiFlash don't support it ?

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two CREATE TABLE statements and the EXPLAIN ANALYZE join query from the issue, then inspect the reported TiFlash warnings. The issue names no source files or tests; done means enum expressions are supported by TiFlash push calculation without those warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, sql
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.