pingcap / pingcap/tiflash

Concurrency issue between `DeltaMergeStore::drop` and `PageStorage::gc`

Open
#8,600 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/storage severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)
2. What did you expect to see? (Required)
3. What did you see instead (Required)

https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-integration-tests/detail/tiflash-ghpr-integration-tests/15604/pipeline

fullstack-test2-logs.tar.gz

[2023-12-23T04:45:37.921Z] fullstack-test2/ddl/alter_drop_table.test: Running
[2023-12-23T04:45:37.921Z]   File: fullstack-test2/ddl/alter_drop_table.test
[2023-12-23T04:45:37.921Z]   Error line: 22
[2023-12-23T04:45:37.921Z]   Error: DBGInvoke __gc_schemas(18446744073709551615)
[2023-12-23T04:45:37.921Z]   Result:
[2023-12-23T04:45:37.921Z]     Received exception from server (version 1.1.54381):
[2023-12-23T04:45:37.921Z]     Code: 1000. DB::Exception: Received from 127.0.0.1:9000. DB::Exception: File not found: /tmp/tiflash/data/db/data/t_253/stable/.del.dmf_1.
[2023-12-23T04:45:37.921Z]   Expected:
[2023-12-23T04:45:37.921Z]     <nothing>
4. What is your TiFlash version? (Required)

master

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with fullstack-test2/ddl/alter_drop_table.test, then inspect the concurrency between DeltaMergeStore::drop and PageStorage::gc described in the issue. Done means the test no longer reports the missing .del.dmf_1 file during schema garbage collection.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.