pingcap / pingcap/tiflash

Avoid exit for ProxyFFI when alloc failure due to memory exceeds limit

Open
#8,464 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

TiFlash introduced memory limit for all queries. When server is under heavy pressure, it is expected to kill queries to release memory instead of calling exit.
#8170 is an example.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #8170 and tracing the ProxyFFI entry point where allocation failure is handled. Confirm how memory-limit pressure currently reaches process exit; done when an allocation failure caused by the query memory limit releases or kills the query without exiting the server.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.