pingcap / pingcap/tiflash

find a proper way to handle fail during proxy initializing

Open
#8,461 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

https://github.com/pingcap/tiflash/blob/68181844e5a9e0643583bd51ddcf03e909d71cdb/dbms/src/Server/Server.cpp#L1040-L1043

Now TiFlash server will keep on waiting for proxy init by checking whether proxy_helper is nullptr. But the proxy may fail before setting proxy. TiFlash can not be aware that proxy has failed, just keep on waiting...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at dbms/src/Server/Server.cpp around lines 1040-1043 and trace how proxy initialization reports success or failure. Determine how the server can distinguish a failed initialization from an unset proxy, then verify that it no longer waits indefinitely when proxy initialization fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.