pingcap / pingcap/tiflash

Remove resource group metric when it's useless

Open
#8,240 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

For now, if resource group is deleted by user, the metric of resource group still exists.
We should clean it. Just like keyspace metric

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in dbms/src/Server/MetricsPrometheus.cpp near the referenced keyspace metric cleanup and compare how resource group metrics are registered and removed. Reproduce or trace resource-group deletion, then verify that its metric no longer remains while existing keyspace metric behavior is preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.