`strptime` in GmSSL library is not a C standard
Open
Nobody has claimed this yet.
type/enhancement
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Enhancement
strptime in GmSSL library is not a C standard and this will cause some errors when building tiflash as:
iso c99 and later do not support implicit function declarations.
The latest codes in GmSSL have removed this function. Hope to upgrade the GmSSL library.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the GmSSL dependency used by TiFlash and reproduce the C99 build failure involving strptime. Done means upgrading the dependency to a version that no longer uses this non-standard function and confirming that TiFlash builds successfully under C99 or later.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100