pingcap / pingcap/tiflash

Use Proxy to parse lock data

Open
#7,384 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

What we want to get from lock is

struct InnerDecodedWriteCFValue
{
    UInt8 write_type;
    Timestamp prewrite_ts;
    std::shared_ptr<const TiKVValue> short_value;
};

However, it happened many times that a new lock type may cause TiFlash to panic. I hereby suggest that we use proxy to decode lock.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. First clarify the proxy interface for decoding lock data and how new lock types should map to InnerDecodedWriteCFValue; done means TiFlash no longer panics when a new lock type is encountered.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases, distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.