pingcap / pingcap/tiflash

DTFile cache is not be abled to evit after restart

Open
#7,314 2 comments 0 reactions 1 assignee View on GitHub

@JinheLin is already working on this.

Since Apr 18, 2023.

component/storage severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

https://github.com/pingcap/tiflash/blob/24ae5cf278143e1bcae53b6aedf675f7dc8b1e00/dbms/src/Interpreters/Settings.h#L222

  • Deploy tiflash with S3 disagg arch
  • Start a RN and execute queries to fill up the DTFileCache
  • Restart the RN and execute more queries
2. What did you expect to see? (Required)

The old cache can be removed if not access any more

3. What did you see instead (Required)

The old cache will be protected until dt_filecache_min_age_seconds is reach. This cause performance regression if the RN is restart and serve a different tenant that access to totally different files.

4. What is your TiFlash version? (Required)

master

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.