pingcap / pingcap/tiflash

Split `FunctionsTiDBConversion.h` and `FunctionsRegexp.h` file

Open
#6,574 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

Compiling FunctionsTiDBConversion.h will take over 9GB memory, it's very slow and easier to OOM when we compile tiflash with multi-threads on a machine with small amount of memory.

  • FunctionsTiDBConversion.h
  • FunctionsRegexp.h

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting FunctionsTiDBConversion.h and the completed FunctionsRegexp.h split for the intended organization. Build TiFlash with multiple threads and measure compilation memory and time before and after the change; done means the conversion header is split and no longer causes the reported memory pressure.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, performance
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.