pingcap / pingcap/tiflash

tpcds-50g-tiflash QUERY_41 performance regression

Open
#6,424 2 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

affects-6.5 component/compute severity/moderate type/bug
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Bug Report

1. Minimal reproduction step (Required)

deploy a TiDB cluster with 1 tiflash and run tpcds 50g

2. What did you expect to see? (Required)
Baseline Elapsed_Time (s): 10.8 

+--------------------------------------+----------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+
| ID                                   | ESTROWS  | ACTROWS | TASK         | ACCESS OBJECT | EXECUTION INFO                                                                                                                                                                                                                                                                                                                                                                | OPERATOR INFO                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  | MEMORY    | DISK |
+--------------------------------------+----------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+
| Projection_16                        | 100.00   | 9       | root         |               | time:10.8s, loops:2, Concurrency:OFF                                                                                                                                                                                                                                                                                                                                          | tpcds50.item.i_product_name                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    | 1.24 KB   | N/A  |
| └─TopN_19                            | 100.00   | 9       | root         |               | time:10.8s, loops:2                                                                                                                                                                                                                                                                                                                                                           | tpcds50.item.i_product_name, offset:0, count:100                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               | 6.28 KB   | N/A  |
|   └─HashAgg_24                       | 841.35   | 9       | root         |               | time:10.8s, loops:7, partial_worker:{wall_time:10.827001219s, concurrency:5, task_num:1, tot_wait:54.134292837s, tot_exec:56.7µs, tot_time:54.134379186s, max:10.826894029s, p95:10.826894029s}, final_worker:{wall_time:10.82703098s, concurrency:5, task_num:5, tot_wait:54.134670959s, tot_exec:313.67µs, tot_time:54.134990877s, max:10.827010785s, p95:10.827010785s}    | group by:tpcds50.item.i_product_name, funcs:firstrow(tpcds50.item.i_product_name)->tpcds50.item.i_product_name, funcs:firstrow(tpcds50.item.i_product_name)->tpcds50.item.i_product_name                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       | 26.0 KB   | N/A  |
|     └─Apply_26                       | 843.33   | 9       | root         |               | time:10.8s, loops:2, Concurrency:OFF, cache:ON, cacheHitRatio:83.077%                                                                                                                                                                                                                                                                                                         | CARTESIAN inner join                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           | 2.59 KB   | N/A  |
|       ├─TableReader_32(Build)        | 843.33   | 845     | root         |               | time:16.8ms, loops:3, cop_task: {num: 1, max: 16.9ms, proc_keys: 0, rpc_num: 1, rpc_time: 16.9ms, copr_cache_hit_ratio: 0.00, distsql_concurrency: 15}                                                                                                                                                                                                                        | data:Selection_31                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              | 46.8 KB   | N/A  |
|       │ └─Selection_31               | 843.33   | 845     | cop[tiflash] |               | tiflash_task:{time:14.5ms, loops:1, threads:1}                                                                                                                                                                                                                                                                                                                                | ge(tpcds50.item.i_manufact_id, 742), le(tpcds50.item.i_manufact_id, 782)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       | N/A       | N/A  |
|       │   └─TableFullScan_30         | 62000.00 | 62000   | cop[tiflash] | table:i1      | tiflash_task:{time:11.5ms, loops:1, threads:1}                                                                                                                                                                                                                                                                                                                                | keep order:false                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               | N/A       | N/A  |
|       └─Selection_33(Probe)          | 0.80     | 9       | root         |               | time:10.2s, loops:152                                                                                                                                                                                                                                                                                                                                                         | gt(Column#45, 0)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               | 380 Bytes | N/A  |
|         └─HashAgg_55                 | 1.00     | 143     | root         |               | time:10.2s, loops:295, partial_worker:{wall_time:10.167143893s, concurrency:5, task_num:9, tot_wait:50.773121791s, tot_exec:128.232µs, tot_time:50.774035271s, max:113.073589ms, p95:100.646321ms}, final_worker:{wall_time:10.17616577s, concurrency:5, task_num:9, tot_wait:50.802177813s, tot_exec:2.144552ms, tot_time:50.804949191s, max:113.104644ms, p95:100.697125ms} | funcs:count(Column#48)->Column#45                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              | 9.86 KB   | N/A  |
|           └─TableReader_57           | 1.00     | 9       | root         |               | time:10.2s, loops:152, cop_task: {num: 143, max: 0s, min: 0s, avg: 0s, p95: 0s, copr_cache_hit_ratio: 0.00}                                                                                                                                                                                                                                                                   | data:ExchangeSender_56                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         | N/A       | N/A  |
|             └─ExchangeSender_56      | 1.00     | 9       | mpp[tiflash] |               | tiflash_task:{proc max:112ms, min:51ms, avg: 69ms, p80:75.6ms, p95:98.9ms, iters:9, tasks:143, threads:143}                                                                                                                                                                                                                                                                   | ExchangeType: PassThrough                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      | N/A       | N/A  |
|               └─HashAgg_38           | 1.00     | 9       | mpp[tiflash] |               | tiflash_task:{proc max:112ms, min:51ms, avg: 69ms, p80:75.6ms, p95:98.9ms, iters:9, tasks:143, threads:143}                                                                                                                                                                                                                                                                   | funcs:count(1)->Column#48                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      | N/A       | N/A  |
|                 └─Selection_54       | 0.03     | 10      | mpp[tiflash] |               | tiflash_task:{proc max:112ms, min:51ms, avg: 69ms, p80:75.6ms, p95:98.9ms, iters:9, tasks:143, threads:143}                                                                                                                                                                                                                                                                   | or(and(eq(tpcds50.item.i_manufact, tpcds50.item.i_manufact), or(or(and(and(eq(tpcds50.item.i_category, "Women"), or(eq(tpcds50.item.i_color, "orchid"), eq(tpcds50.item.i_color, "papaya"))), and(or(eq(tpcds50.item.i_units, "Pound"), eq(tpcds50.item.i_units, "Lb")), or(eq(tpcds50.item.i_size, "petite"), eq(tpcds50.item.i_size, "medium")))), and(and(eq(tpcds50.item.i_category, "Women"), or(eq(tpcds50.item.i_color, "burlywood"), eq(tpcds50.item.i_color, "navy"))), and(or(eq(tpcds50.item.i_units, "Bundle"), eq(tpcds50.item.i_units, "Each")), or(eq(tpcds50.item.i_size, "N/A"), eq(tpcds50.item.i_size, "extra large"))))), or(and(and(eq(tpcds50.item.i_category, "Men"), or(eq(tpcds50.item.i_color, "bisque"), eq(tpcds50.item.i_color, "azure"))), and(or(eq(tpcds50.item.i_units, "N/A"), eq(tpcds50.item.i_units, "Tsp")), or(eq(tpcds50.item.i_size, "small"), eq(tpcds50.item.i_size, "large")))), and(and(eq(tpcds50.item.i_category, "Men"), or(eq(tpcds50.item.i_color, "chocolate"), eq(tpcds50.item.i_color, "cornflower"))), and(or(eq(tpcds50.item.i_units, "Bunch"), eq(tpcds50.item.i_units, "Gross")), or(eq(tpcds50.item.i_size, "petite"), eq(tpcds50.item.i_size, "medium"))))))), and(eq(tpcds50.item.i_manufact, tpcds50.item.i_manufact), or(or(and(and(eq(tpcds50.item.i_category, "Women"), or(eq(tpcds50.item.i_color, "salmon"), eq(tpcds50.item.i_color, "midnight"))), and(or(eq(tpcds50.item.i_units, "Oz"), eq(tpcds50.item.i_units, "Box")), or(eq(tpcds50.item.i_size, "petite"), eq(tpcds50.item.i_size, "medium")))), and(and(eq(tpcds50.item.i_category, "Women"), or(eq(tpcds50.item.i_color, "snow"), eq(tpcds50.item.i_color, "steel"))), and(or(eq(tpcds50.item.i_units, "Carton"), eq(tpcds50.item.i_units, "Tbl")), or(eq(tpcds50.item.i_size, "N/A"), eq(tpcds50.item.i_size, "extra large"))))), or(and(and(eq(tpcds50.item.i_category, "Men"), or(eq(tpcds50.item.i_color, "purple"), eq(tpcds50.item.i_color, "gainsboro"))), and(or(eq(tpcds50.item.i_units, "Dram"), eq(tpcds50.item.i_units, "Unknown")), or(eq(tpcds50.item.i_size, "small"), eq(tpcds50.item.i_size, "large")))), and(and(eq(tpcds50.item.i_category, "Men"), or(eq(tpcds50.item.i_color, "metallic"), eq(tpcds50.item.i_color, "forest"))), and(or(eq(tpcds50.item.i_units, "Gram"), eq(tpcds50.item.i_units, "Ounce")), or(eq(tpcds50.item.i_size, "petite"), eq(tpcds50.item.i_size, "medium")))))))) | N/A       | N/A  |
|                   └─TableFullScan_53 | 62000.00 | 8866000 | mpp[tiflash] | table:item    | tiflash_task:{proc max:25ms, min:8.83ms, avg: 17.7ms, p80:19.7ms, p95:22.9ms, iters:143, tasks:143, threads:143}                                                                                                                                                                                                                                                              | keep order:false                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               | N/A       | N/A  |
+--------------------------------------+----------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+

4. What is your TiFlash version? (Required)

good: commit 77108d5efc869867c706c4f0b88ee7a50f07ce93
bad: commit d605a40aacaa465bf1fab8db975a0535c37aad13

https://github.com/pingcap/tiflash/compare/77108d5...d605a40

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.