pingcap / pingcap/tiflash

MPP Support warnings

Open
#6,358 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/compute component/mpp type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

Now mpp don't support warnings.

  • cop
    6CCwk1Sw2z
  • mpp
    47trf3AiKo

For supporting warnings, we should acquire warnings from exchange and send warning reponse in MPPTask::finishWrite, just like https://github.com/pingcap/tiflash/blob/e7be8e7f06af59a0359287b9849bdd436666e3b4/dbms/src/Flash/Coprocessor/UnaryDAGResponseWriter.cpp#L61-L72

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at MPPTask::finishWrite and compare its current behavior with dbms/src/Flash/Coprocessor/UnaryDAGResponseWriter.cpp, especially lines 61-72 referenced in the issue. Trace how warnings are acquired from the exchange and verify that MPP sends the corresponding warning response when the write finishes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.