pingcap / pingcap/tiflash

DeltaMergeStore::BackgroundTask better to use weak_ptr<Segment>

Open
#6,341 0 comments 0 reactions 1 assignee View on GitHub

@flowbehappy is already working on this.

Since Nov 21, 2022.

component/storage type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

Currently, there are two places that reference Segment instances:

  1. DeltaMergeStore ::segments
  2. DeltaMergeStore ::background_pool and DeltaMergeStore::blockable_background_pool

We can use std::weak_ptr<Segment> to reference in 2, so Segment instances can be freed right after they are removed from 1.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.