tcp_port_secure in config is useless currenlty.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Enhancement
In https://github.com/pingcap/tiflash/blob/master/dbms/src/Server/Server.cpp#L678, I found that we can't satisfy the condition, then TiFlash can't create a tcp server with ssl.
There may come through 2 bad case.
-
The worst case is when
(1) config.has("tcp_port_secure") == true
(2) config.has("tcp_port") == false
TiFlash will not create a tcp server. -
The second case is when:
(1) config.has("tcp_port_secure")&& ! security_config->has_tls_config == true
(2) config.has("tcp_port") == false
The cert in secuirty_config is useless.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at dbms/src/Server/Server.cpp around line 678 and trace how tcp_port_secure, tcp_port, and security_config->has_tls_config affect TCP server creation. Confirm the intended behavior for secure TCP configuration when tcp_port is absent and when TLS settings are present, then validate both configuration cases with the relevant server tests or checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100