pingcap / pingcap/tiflash

Refine legends of metrics `Request Duration` and `Request Handle Duration`.

Open
#6,305 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

The query types are grouped in the metrics Request Duration and Request Handle Duration, this reduces the amount of information we can get from the metric graph.
image

We should refine it.

Firstly, we can expand the type dimension, like graph Cop task memory usage:
image

Secondly, we can separate the le to different grpah.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named. Start by locating the metric definitions for Request Duration and Request Handle Duration, then inspect how their type and le dimensions are represented; done means the legends expose the query type and separate the le values into distinct graphs.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability-sre
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.