pingcap / pingcap/tiflash

Optimize the StringComparison

Open
#6,114 0 comments 0 reactions 1 assignee View on GitHub

@Lloyd-Pottiger is already working on this.

Since Oct 12, 2022.

type/enhancement type/performance
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

The implement of StringComparison is not good, take StringEqualsImpl::stringVectorStringVector as an example:

we need optimized it by

  • better cache locality
  • use std::string_view instead of std::string
  • use mem_utils::memoryEqual instead of !std::memcmp

https://github.com/pingcap/tiflash/blob/e6f48a68af4473514aa27f7ce1c50706116303c0/dbms/src/Functions/FunctionsComparison.h#L445-L455

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.