pingcap / pingcap/tiflash

Add noexcept for functions that will not throw Exception.

Open
#5,929 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

We recommended you apply noexcept to any function that never allows an exception to propagate up the call stack. When a function is declared noexcept, it enables the compiler to generate more efficient code in several different contexts.
https://learn.microsoft.com/en-us/cpp/cpp/noexcept-cpp?view=msvc-170

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are identified. Read the linked Microsoft noexcept guidance, then audit the C++ functions that cannot allow exceptions to propagate and determine which declarations are appropriate; done means the applicable functions are identified and their exception behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.