pingcap / pingcap/tiflash

Remove useless clickhouse aggregate functions

Open
#5,751 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/compute good first issue help wanted type/enhancement
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Enhancement

Some of aggregate functions are ClickHouse-specific, so they are useless for TiFlash, we can just remove the code.

  • anyHeavy
  • anyLast
  • argMin
  • argMax
  • avgWeighted
  • topK
  • topKWeighted
  • groupArrayInsertAt
  • groupArrayMovingAvg
  • groupArrayMovingSum
  • groupBitmap
  • groupBitmapAnd
  • groupBitmapOr
  • groupBitmapXor
  • sumWithOverflow
  • sumMap
  • minMap
  • maxMap
  • skewSamp
  • skewPop
  • kurtSamp
  • kurtPop
  • quantile
  • quantiles
  • quantileExact
  • quantileExactLow
  • quantileExactHigh
  • quantileExactWeighted
  • quantileTiming
  • quantileTimingWeighted
  • quantileDeterministic
  • quantileTDigest
  • quantileTDigestWeighted
  • quantileBFloat16
  • quantileBFloat16Weighted
  • simpleLinearRegression
  • stochasticLinearRegression
  • stochasticLogisticRegression
  • categoricalInformationValue

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the checklist in the issue as the scope, starting by locating the implementations and registrations for the listed aggregate functions in the TiFlash codebase. Check whether each function is still referenced before removing it, and verify that the project builds and its relevant tests pass with the functions no longer available.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.