pingcap / pingcap/tiflash

Unified configuration management framework

Open
#5,585 0 comments 5 reactions 1 assignee View on GitHub

@Lloyd-Pottiger is already working on this.

Since Aug 10, 2022.

type/feature-request
Dominant language
C++
Stars
1k
Forks
423
Avg merge
1d 15h
Merged PRs (30d)
24

Description

Feature Request

Is your feature request related to a problem? Please describe:

Now, the configuration is a mess. Some are configured by toml file, and some are recorded in the dbms/src/Interpreters/Settings.h. We initialize components by global_context and the default value has been decided in compiler time, even if the configuration has not been loaded, components can run smoothly.
There are cause some potential risks:

  1. Some components initialize with default settings rather than the configuration in the input configuration file.
  2. The configuration has changed during running, but we can not perceive it.

Describe the feature you'd like:

We need a unified configuration management framework in order to

  1. manage the configuration of different components together
  2. real-time awareness of the configuration.
  3. an interface to get the configuration for users

Milestone

  • collect and classify all the configuration
  • add a controller to manage configuration globally
  • use the controller in all tiflash components

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.