Drop rowkey_column_size
Open
Nobody has claimed this yet.
type/enhancement
- Dominant language
- C++
- Stars
- 1k
- Forks
- 423
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 24
Description
Enhancement
rowkey_column_size is not necessary:
-
For common handle PK, all primary key columns are just stored together in _tidb_rowid.
-
For int handle PK, there will be only 1 PK column.
-
For implicit handle PK, there will be only 1 PK column (_tidb_rowid).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start with a repository-wide search for rowkey_column_size and trace its uses through the rowkey handling paths. Remove the parameter and confirm the common-handle, int-handle, and implicit-handle cases remain covered without it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100